/** * tests/unit/workflow_launch_regression.test.ts * * 回归 BS-新146 / BS-新147 / BS-新148 — workflow launch 三连 bug. * * BS-新146 (L1): `--no-verify` 选项 commander 映射到 `opts.verify = false`, * 但 launch.ts 源码读 `opts.noVerify` (永远 undefined), verify 永远跑. * 修复: Opts.verify 字段 + `if (opts.verify === false)` 判定. * * BS-新147 (L2): `/workflow/operator/List/2` 响应是 `{code, msg, data: {list, pagination}}`, * launch.ts 源码用 `ops.data || []` 当数组, 实际 ops.data 是 {list, pagination}, * → ops.find 抛 'is not a function'. * 修复: 镜像 tasks.ts:62-71, `r.data?.list || []`. * * BS-新148 (L3): CurrentUser 真实响应是嵌套结构 (me.userInfo.userId), 顶层无 userId, * → ${currentUser} lint 永远 'no current user'. 修复见 workflow_approver_resolve.test.ts. * * 测试策略: * - L1: 直接 parse Commander 命令, 验证 --no-verify → opts.verify === false. * - L2: 单元测试 webapi 解析逻辑 (不依赖 JnpfClient, 直接喂 JnpfResp 包装的响应). * - L2b: 演示旧 bug ops.find 抛错的 fixture, 防止有人改回旧的 ops.data || []. */ import { describe, expect, it } from 'vitest' import { buildWorkflowLaunchCommand } from '../../src/commands/workflow/launch.ts' describe('workflow launch regression BS-新146/147/148', () => { // ===== L1: --no-verify 选项 commander 解析 ===== describe('BS-新146 (L1): --no-verify 选项', () => { it('--no-verify 传 → opts.verify === false', async () => { // commander 把 --no-foo 映射为 opts.foo = false. 我们要看 launch.ts 真的尊重这个. // 通过执行 --help 看 commander 是否接受 (不会抛 unknown option). const cmd = buildWorkflowLaunchCommand() // 用 parse 模拟命令行; action 不会真跑 (mock 缺失会报, 但 parse 应该成功). try { await cmd.parseAsync([ '--flowId', 'F1', '--formId', 'fid1', '--data', '{}', '--no-verify', ], { from: 'user' }) } catch { // action 可能因 mock 缺失抛错, 我们只关心 parse 阶段成功. } const opts = cmd.opts<{ verify?: boolean }>() expect(opts.verify).toBe(false) }) it('不传 --no-verify → opts.verify = true (commander --no-X 默认值)', async () => { // commander --no-X 语义: opts.X 默认 true, 传 --no-X 时才为 false. // launch.ts 修后: 不传 --no-verify → opts.verify === true → 走 verify 严格模式 (默认). const cmd = buildWorkflowLaunchCommand() try { await cmd.parseAsync([ '--flowId', 'F1', '--formId', 'fid1', '--data', '{}', ], { from: 'user' }) } catch { // ignore action error } const opts = cmd.opts<{ verify?: boolean }>() expect(opts.verify).toBe(true) }) }) // ===== L2: operator list 响应解析 ===== describe('BS-新147 (L2): operator list 响应解析', () => { it('真实 JNPF 嵌套响应 {code, msg, data: {list, pagination}} → 正确解析为数组', () => { // 镜像 launch.ts:103-119 修复后的解析路径. // 不依赖 JnpfClient, 直接喂 JnpfResp 包装的响应验证逻辑. type Op = { id?: string; taskNodeId?: string; userId?: string } const fakeResp = { code: 200, msg: 'Success', data: { list: [ { id: 'op1', taskNodeId: 't1', userId: '349057407209541' }, { id: 'op2', taskNodeId: 't2', userId: '349057407209542' }, ], pagination: { total: 2, currentPage: 1, pageSize: 20 }, }, } // 这是修复后的逻辑: r.data?.list || []. const ops: Op[] = fakeResp.data?.list || [] expect(Array.isArray(ops)).toBe(true) expect(ops).toHaveLength(2) expect(ops.find((o) => o.userId === '349057407209541')?.id).toBe('op1') }) it('回归 fixture: 旧 bug 路径 ops.data 当数组 → ops.find 抛错', () => { // 防回归: 证明旧的 ops.data || [] 会抛 'is not a function'. const fakeResp = { code: 200, msg: 'Success', data: { list: [{ id: 'op1' }], pagination: { total: 1 }, }, } // 旧代码: const ops = await c.get(...); return ops.data || [] const opsOld: { list?: unknown[] } = fakeResp.data || {} expect(() => (opsOld as unknown as { find: (f: (o: unknown) => boolean) => unknown }).find(() => true)).toThrow( /is not a function/, ) }) it('code !== 200 → 空数组 (verify 失败兜底)', () => { const fakeResp = { code: 600, msg: 'Login expired', data: null } // 修复后逻辑 if (fakeResp.code && fakeResp.code !== 200) { expect([].length).toBe(0) return } throw new Error('should have short-circuited on non-200 code') }) it('data 为 null → 空数组 fallback', () => { const fakeResp: { code: number; msg: string; data: { list?: unknown[]; pagination?: { total?: number } } | null } = { code: 200, msg: 'Success', data: null } const ops: unknown[] = fakeResp.data?.list || [] expect(ops).toEqual([]) }) it('data.list 为 undefined → 空数组 fallback', () => { const fakeResp: { code: number; msg: string; data: { list?: unknown[]; pagination?: { total?: number } } } = { code: 200, msg: 'Success', data: { pagination: { total: 0 } } } const ops: unknown[] = fakeResp.data?.list || [] expect(ops).toEqual([]) }) }) })