Files
dacli/tests/unit/workflow_auto_assign_admin.test.ts
T
sswandClaude 367d90e4d1 fix(dacli): R3 实战 3 bug 修复 (form create 残留/autoRelease 400/workflow --ai 兜底)
- form create --ai 失败留 state=0 残留 (R3 P0)
  - 加 src/commands/form/_cleanup.ts + cleanupResidueForms helper
  - 集成到 wrapCommand 4 个 ctx.fail 路径 (T3 回读失败 / release 重试失败 / 外层 catch)
  - 默认 ON, --no-cleanup-on-fail 关闭
- form create --autoRelease 报 400 (R1 P6.2 + R3 P1)
  - release 失败首次 400 时 GET 一次 formInfo 刷新后端缓存, 再 retry release
  - 现有 retry + 指数 backoff (500/1000/2000ms) 保留, additive safety net
- workflow create --ai lint 失败直接 throw (R1 P5 + R3 P2)
  - 加 src/commands/workflow/_auto_assign_admin.ts + autoAssignAdmin helper
  - semanticLint 失败全为 missing assignee/candidate 类时, 自动注入 admin 重 lint
  - 兜底后仍失败才 throw (非 assignee 类错保持原 throw)
- 2 vitest tests: form_create_cleanup_residue (8 cases), workflow_auto_assign_admin (7 cases)
  - 含端到端 R3 实战场景: 4 userTask 缺 PO → autoAssignAdmin → re-lint OK
- workflow CreateOpts 加 forceLint/keepOnFail 字段 (历史缺失, TS 兜底)
- form CreateOpts/DeleteOpts 加 force 字段 (历史缺失, TS 兜底)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
2026-07-29 17:39:39 +08:00

131 lines
5.6 KiB
TypeScript

/**
* tests/unit/workflow_auto_assign_admin.test.ts
*
* Bug 3 兜底 (tdd6 R3 2026-07-29 + R1 P5 历史踩坑):
* workflow --ai 生成的 BPMN 偶尔只输出 camunda:assignee, 缺 userTask.potentialOwner,
* semanticLint 报 'no assignee or candidate' 全员失败, 直接 throw.
* 修复: autoAssignAdmin 注入 admin potentialOwner 给所有缺候选的 userTask.
*
* 测试覆盖:
* 1. 注入 (1 个 userTask 无 potentialOwner → 加 admin)
* 2. 不覆盖 (已有 user1 → 不变)
* 3. 多个 userTask (混合, 部分已有 PO 部分无 → 只补缺失)
* 4. 空 XML / 解析失败 → 返回原 XML
* 5. 没有 userTask → 返回原 XML
* 6. 注入后, semanticLint 重跑 OK (端到端验证)
*/
import { describe, expect, it } from 'vitest'
import { autoAssignAdmin } from '../../src/commands/workflow/_auto_assign_admin.ts'
import { semanticLint } from '../../src/commands/workflow/_semantic_lint.ts'
describe('workflow autoAssignAdmin (Bug 3 兜底)', () => {
it('注入 potentialOwner admin 到无候选 userTask', async () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" id="x">
<process id="P_1" isExecutable="true">
<startEvent id="start"/>
<userTask id="t1" name="T1"/>
<endEvent id="end"/>
<sequenceFlow id="f1" sourceRef="start" targetRef="t1"/>
<sequenceFlow id="f2" sourceRef="t1" targetRef="end"/>
</process>
</definitions>`
const result = await autoAssignAdmin(xml)
// 注: bpmn-moddle 序列化为 <expression xsi:type="tFormalExpression">admin</expression>
expect(result).toContain('<potentialOwner')
expect(result).toContain('admin')
// 验证含 bpmn:resourceAssignmentExpression 嵌套 (BPMN 标准 PO 结构)
expect(result).toContain('resourceAssignmentExpression')
})
it('保留已有 potentialOwner (user1 不被覆盖)', async () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" id="x">
<process id="P_1" isExecutable="true">
<startEvent id="start"/>
<userTask id="t1" name="T1">
<potentialOwner id="po1"><resourceAssignmentExpression><formalExpression>user1</formalExpression></resourceAssignmentExpression></potentialOwner>
</userTask>
<endEvent id="end"/>
<sequenceFlow id="f1" sourceRef="start" targetRef="t1"/>
<sequenceFlow id="f2" sourceRef="t1" targetRef="end"/>
</process>
</definitions>`
const result = await autoAssignAdmin(xml)
// t1 的 potentialOwner 应保留为 user1, 不被覆盖
// 注: bpmn-moddle 序列化时会将 <formalExpression> 重写成 <expression xsi:type="tFormalExpression">
expect(result).toContain('user1')
expect(result).not.toContain('admin')
})
it('多个 userTask 混合: 已有 PO 不变, 缺失 PO 注入 admin', async () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" id="x">
<process id="P_1" isExecutable="true">
<startEvent id="start"/>
<userTask id="t1" name="T1"/>
<userTask id="t2" name="T2">
<potentialOwner id="po2"><resourceAssignmentExpression><formalExpression>manager1</formalExpression></resourceAssignmentExpression></potentialOwner>
</userTask>
<userTask id="t3" name="T3"/>
<endEvent id="end"/>
</process>
</definitions>`
const result = await autoAssignAdmin(xml)
// t2 的 manager1 保留 (bpmn-moddle 序列化为 <expression xsi:type="tFormalExpression">manager1</expression>)
expect(result).toContain('manager1')
// t1 + t3 被注入 admin (期望 2 个 admin)
const adminMatches = result.match(/admin/g) || []
expect(adminMatches.length).toBeGreaterThanOrEqual(2)
// 不应有 manager1 被覆盖为 admin
expect(result).not.toMatch(/manager1.*admin|admin.*manager1/)
})
it('空 XML → 返回原值, 不抛', async () => {
expect(await autoAssignAdmin('')).toBe('')
expect(await autoAssignAdmin(' ')).toBe(' ')
})
it('无 userTask → 返回原值', async () => {
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<definitions xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" id="x">
<process id="P_1" isExecutable="true">
<startEvent id="start"/>
<endEvent id="end"/>
<sequenceFlow id="f1" sourceRef="start" targetRef="end"/>
</process>
</definitions>`
const result = await autoAssignAdmin(xml)
expect(result).toBe(xml)
})
it('解析失败 → 返回原值, 不抛', async () => {
const broken = '<not-xml-at-all>'
expect(await autoAssignAdmin(broken)).toBe(broken)
})
it('端到端: 注入后 semanticLint 重跑 OK (R3 实战场景)', async () => {
// R3: 4 userTask 缺 potentialOwner, semanticLint 报 4 errors
// 修复: autoAssignAdmin 注入 admin → re-lint → OK
const xml = `<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL">
<bpmn:process id="p1">
<bpmn:startEvent id="s1"/>
<bpmn:userTask id="t1"/>
<bpmn:userTask id="t2"/>
<bpmn:userTask id="t3"/>
<bpmn:userTask id="t4"/>
<bpmn:endEvent id="e1"/>
</bpmn:process>
</bpmn:definitions>`
const before = await semanticLint(xml, { webapi: {} })
expect(before.ok).toBe(false)
expect(before.errors.filter((e) => /missing assignee|candidate/.test(e)).length).toBe(4)
// R3 兜底: autoAssignAdmin → re-lint
const fixed = await autoAssignAdmin(xml)
const after = await semanticLint(fixed, { webapi: {} })
expect(after.ok).toBe(true)
expect(after.errors).toEqual([])
})
})