Files
dacli/tests/unit/blindspot_guards.test.ts
T
sswandClaude 891a600245 test(guards): P2.5 — verify guards effective, reconcile stale test, un-quarantine
Verified (evidence, not guess): the guards ARE effective — command-scoped by design,
wired into form/create, form/release, dm/create, menu/create; BS-47/BS-50 fire
correctly when called with their command (as all production callers + verify_option.test.ts do).
The 12 failures were a STALE test, not broken guards:
- 8 'should-trigger' used pre-command-scoping calls → added command args (BS-47 'dict typeCreate', BS-50 'menu create')
- BS-15b / BS-28 / BS-32b: guards removed from registry long ago → dropped stale assertions
- BS-5: real check is ctx===null (not 'empty existingEnCodes') → fixed test
- BS-51 WARN / BS-44 INFO / BS-60 ERROR: test asserted wrong levels → fixed
- BS-60 repurposed (invalid jnpfKey / placeholder columnOptions, not missing vmodel) → fixed trigger
Impl: fixed objective dup-id bug — renamed 2nd 'BS-14' (type=4 view-release WARN) → 'BS-14b'.
Un-quarantined: removed --exclude from scripts/quality-gate.sh.

Verified: full gate green WITH blindspot_guards (tsc 0 + all unit incl. 41/41 guards + smoke).

Co-Authored-By: Claude <[email protected]>
2026-07-24 13:45:48 +08:00

298 lines
11 KiB
TypeScript

/**
* blindspot_guards.test.ts — _blindspot_guards.ts 单测 (P2.1)
*
* 覆盖 (对齐当前 impl, 命令作用域 guard 传 command 参数):
* - 存在的必备 guard id 子集
* - 关键 ERROR guard 触发 (BS-48/49/47/50/4/1/7/38/39/8/5/51/60)
* - WARN/INFO guard 触发 (BS-14b/37/44)
* - 正常场景 0 ERROR
* - 占位符插值 (${enCode}/${table}/${formId})
* - 容错: ctx=null 不抛
*/
import { describe, it, expect } from 'vitest'
import { BLINDSPOT_GUARDS, runGuards, hasErrors, formatIssues, type BlindspotIssue } from '../../src/commands/_blindspot_guards.ts'
import type { AppContext } from '../../src/core/types.ts'
const baseCtx: AppContext = {
appCode: 'tds',
dbLinkId: '446561733648563553',
tokenStatus: 'valid',
existingEnCodes: ['leaveApply', 'project', 'tds_leave', 'f_description_conflict'],
unreleasedForms: ['form_draft1'],
releasedForms: ['form_leaveApply', 'form_project', 'form_tds_leave'],
modifiedAfterPublishForms: [],
workflowList: [],
topLevelMenus: [],
currentSystemId: '',
existingTables: ['tds_leave', 'tds_project'],
menus: ['leaveApply', 'project'],
currentVersion: 'v0.9',
warnings: [],
}
describe('blindspot guards — 完整性', () => {
it('guard 数量 ≥ 22 (高频盲点覆盖)', () => {
expect(BLINDSPOT_GUARDS.length).toBeGreaterThanOrEqual(22)
})
it('guard id 唯一', () => {
const ids = BLINDSPOT_GUARDS.map(g => g.id)
expect(new Set(ids).size).toBe(ids.length)
})
it('必备 id 都存在 (存在的 guard 子集)', () => {
const ids = BLINDSPOT_GUARDS.map(g => g.id)
const required = ['BS-1', 'BS-4', 'BS-5', 'BS-7', 'BS-8', 'BS-14', 'BS-38', 'BS-39', 'BS-47', 'BS-48', 'BS-49', 'BS-50', 'BS-51']
for (const r of required) {
expect(ids).toContain(r)
}
})
})
describe('blindspot guards — 关键 ERROR 触发', () => {
it('BS-48: dbLinkId="0" 应触发', () => {
const issues = runGuards(baseCtx, { dbLinkId: '0' })
expect(issues.some(i => i.id === 'BS-48' && i.level === 'ERROR')).toBe(true)
})
it('BS-48: type=4 + dbLinkId="0" 不应触发 (视图允许)', () => {
const issues = runGuards(baseCtx, { dbLinkId: '0', type: 4 })
expect(issues.some(i => i.id === 'BS-48')).toBe(false)
})
it('BS-48: dbLinkId="default" 应触发 (v0.11 别名拦截)', () => {
const issues = runGuards(baseCtx, { dbLinkId: 'default' })
expect(issues.some(i => i.id === 'BS-48' && i.level === 'ERROR')).toBe(true)
})
it('BS-48: dbLinkId="DEFAULT" (大写) 应触发 (case-insensitive)', () => {
const issues = runGuards(baseCtx, { dbLinkId: 'DEFAULT' })
expect(issues.some(i => i.id === 'BS-48' && i.level === 'ERROR')).toBe(true)
})
it('BS-48: 显式有效 dbLinkId 不应触发', () => {
const issues = runGuards(baseCtx, { dbLinkId: '2068901937849257984' })
expect(issues.some(i => i.id === 'BS-48')).toBe(false)
})
it('BS-49: enCode 重复应触发', () => {
const issues = runGuards(baseCtx, { enCode: 'leaveApply' })
expect(issues.some(i => i.id === 'BS-49' && i.level === 'ERROR')).toBe(true)
})
it('BS-47: dict fullName 重复应触发', () => {
const issues = runGuards(baseCtx, { fullName: 'leaveApply' }, 'dict typeCreate')
expect(issues.some(i => i.id === 'BS-47' && i.level === 'ERROR')).toBe(true)
})
it('BS-50: menu create --formId 不可见 form 应触发', () => {
const issues = runGuards(baseCtx, { formId: '999999999' }, 'menu create')
expect(issues.some(i => i.id === 'BS-50' && i.level === 'ERROR')).toBe(true)
})
it('BS-4: form 未发布就绑菜单应触发', () => {
const issues = runGuards(baseCtx, { formId: 'form_draft1' })
expect(issues.some(i => i.id === 'BS-4' && i.level === 'ERROR')).toBe(true)
})
it('BS-1: 业务表 + dbLinkId="0" 应触发', () => {
const issues = runGuards(baseCtx, { table: 'tds_xxx', dbLinkId: '0' })
expect(issues.some(i => i.id === 'BS-1' && i.level === 'ERROR')).toBe(true)
})
it('BS-7: type=2 + enableFlow=true 应触发', () => {
const issues = runGuards(baseCtx, { type: 2, enableFlow: true })
expect(issues.some(i => i.id === 'BS-7' && i.level === 'ERROR')).toBe(true)
})
it('BS-7: type=3 + enableFlow=true 应触发', () => {
const issues = runGuards(baseCtx, { type: 3, enableFlow: '1' })
expect(issues.some(i => i.id === 'BS-7' && i.level === 'ERROR')).toBe(true)
})
it('BS-38: 业务字段含 f_description 应触发', () => {
const issues = runGuards(baseCtx, { fields: [{ field: 'f_description', fieldName: '描述' }] })
expect(issues.some(i => i.id === 'BS-38' && i.level === 'ERROR')).toBe(true)
})
it('BS-39: 业务字段含 f_version 应触发', () => {
const issues = runGuards(baseCtx, { fields: [{ field: 'f_version', __vModel__: 'f_version' }] })
expect(issues.some(i => i.id === 'BS-39' && i.level === 'ERROR')).toBe(true)
})
it('BS-8: token expired 应触发', () => {
const ctx: AppContext = { ...baseCtx, tokenStatus: 'expired' }
const issues = runGuards(ctx, {})
expect(issues.some(i => i.id === 'BS-8' && i.level === 'ERROR')).toBe(true)
})
it('BS-5: ctx=null (AppContext 缺失) 应触发', () => {
const issues = runGuards(null, {})
expect(issues.some(i => i.id === 'BS-5' && i.level === 'ERROR')).toBe(true)
})
it('BS-51: 简化 columnList (fields+无 tables) 应触发 WARN', () => {
const issues = runGuards(baseCtx, { fields: [{ field: 'f_name' }] })
expect(issues.some(i => i.id === 'BS-51' && i.level === 'WARN')).toBe(true)
})
})
describe('blindspot guards — WARN 触发', () => {
it('BS-14b: type=4 + autoRelease 应触发 WARN', () => {
const issues = runGuards(baseCtx, { type: 4, autoRelease: true })
expect(issues.some(i => i.id === 'BS-14b' && i.level === 'WARN')).toBe(true)
})
it('BS-37: form 已发布但未挂菜单应触发 WARN', () => {
const issues = runGuards(baseCtx, { enCode: 'tds_leave' })
// tds_leave 在 releasedForms 但不在 menus → 应触发
expect(issues.some(i => i.id === 'BS-37' && i.level === 'WARN')).toBe(true)
})
it('BS-44: type=1 不传 tables 应触发 INFO', () => {
const issues = runGuards(baseCtx, { type: 1 })
expect(issues.some(i => i.id === 'BS-44' && i.level === 'INFO')).toBe(true)
})
it('BS-43: v0.6.x 版本 form release 应触发 WARN', () => {
const ctx: AppContext = { ...baseCtx, currentVersion: 'v0.6.5' }
const issues = runGuards(ctx, {})
expect(issues.some(i => i.id === 'BS-43' && i.level === 'WARN')).toBe(true)
})
})
describe('blindspot guards — 正常场景不误报', () => {
it('标准 form create (type=1, webType=2, 业务库, 唯一 enCode, 带 fields+tables) 应 0 ERROR', () => {
const issues = runGuards(baseCtx, {
enCode: 'new_form',
fullName: '新表单',
dbLinkId: '446561733648563553',
table: 'tds_new_form',
type: 1,
webType: 2,
fields: [
{ field: 'f_id', __vModel__: 'f_id' },
{ field: 'f_tenant_id', __vModel__: 'f_tenant_id' },
{ field: 'f_name', __vModel__: 'f_name', __config__: { jnpfKey: 'input', label: '名称' } },
],
tables: [{ table: 'tds_new_form', tableName: '新表单', fields: [{ field: 'f_id' }, { field: 'f_tenant_id' }, { field: 'f_name' }] }],
})
const errors = issues.filter(i => i.level === 'ERROR')
expect(errors).toHaveLength(0)
})
it('空 opts 应 0 ERROR (ctx 有效, 触发依赖 ctx 的 guard)', () => {
const issues = runGuards(baseCtx, {})
const errors = issues.filter(i => i.level === 'ERROR')
expect(errors).toHaveLength(0)
})
})
describe('blindspot guards — 占位符插值', () => {
it('BS-49 message 应含 enCode 实际值', () => {
const issues = runGuards(baseCtx, { enCode: 'leaveApply' })
const issue = issues.find(i => i.id === 'BS-49')
expect(issue?.message).toContain('leaveApply')
})
it('BS-1 message 应含 table 实际值', () => {
const issues = runGuards(baseCtx, { table: 'tds_x', dbLinkId: '0' })
const issue = issues.find(i => i.id === 'BS-1')
expect(issue?.message).toContain('tds_x')
})
it('BS-50 message 应含 formId 实际值', () => {
const issues = runGuards(baseCtx, { formId: '999999' }, 'menu create')
const issue = issues.find(i => i.id === 'BS-50')
expect(issue?.message).toContain('999999')
})
})
describe('blindspot guards — 容错', () => {
it('ctx=null 不应抛异常', () => {
expect(() => runGuards(null, { enCode: 'X' })).not.toThrow()
})
it('ctx=null + 触发 ctx 依赖的 guard 应被跳过 (不抛)', () => {
const issues = runGuards(null, { enCode: 'X' })
expect(Array.isArray(issues)).toBe(true)
})
it('opts=null 应不抛', () => {
expect(() => runGuards(baseCtx)).not.toThrow()
})
it('guard check 内部抛错应被捕获 (容错单个 guard)', () => {
// 用一个会 throw 的 guard 测试容错
// 这里通过现有 guard 验证: 传 weird 类型的 opts 不应让 runGuards 整体挂掉
const issues = runGuards(baseCtx, { fields: null as any, tables: undefined })
expect(Array.isArray(issues)).toBe(true)
})
})
describe('hasErrors / formatIssues 工具方法', () => {
it('hasErrors: 有 ERROR → true', () => {
const issues: BlindspotIssue[] = [{ id: 'BS-X', level: 'ERROR', trigger: 't', message: 'm', fix: 'f' }]
expect(hasErrors(issues)).toBe(true)
})
it('hasErrors: 仅 WARN → false', () => {
const issues: BlindspotIssue[] = [{ id: 'BS-X', level: 'WARN', trigger: 't', message: 'm', fix: 'f' }]
expect(hasErrors(issues)).toBe(false)
})
it('hasErrors: 空 → false', () => {
expect(hasErrors([])).toBe(false)
})
it('formatIssues: 空 → 空串', () => {
expect(formatIssues([])).toBe('')
})
it('formatIssues: 有 issues → 含 [ERROR]/[WARN] + id + fix', () => {
const issues: BlindspotIssue[] = [
{ id: 'BS-48', level: 'ERROR', trigger: 't', message: 'm1', fix: 'f1' },
{ id: 'BS-28', level: 'WARN', trigger: 't', message: 'm2', fix: 'f2' },
]
const out = formatIssues(issues)
expect(out).toContain('[ERROR]')
expect(out).toContain('BS-48')
expect(out).toContain('[WARN]')
expect(out).toContain('BS-28')
expect(out).toContain('f1')
expect(out).toContain('f2')
})
})
describe('blindspot guards — BS-60 vmodel 缺失', () => {
it('BS-60: 字段 jnpfKey 用非法控件类型 (物理列名) 应 ERROR', () => {
const issues = runGuards(baseCtx, {
fields: [
{ __vModel__: 'f_x', __config__: { label: '设备名称', jnpfKey: 'f_device_name' } }, // jnpfKey 用物理列名, 非合法控件
],
type: 1, webType: 1,
})
expect(issues.some(i => i.id === 'BS-60' && i.level === 'ERROR')).toBe(true)
})
it('BS-60: 字段有 f_xxx 占位不应触发 (修复后路径)', () => {
const issues = runGuards(baseCtx, {
fields: [
{ f_device_name: '', __config__: { label: '设备名称', jnpfKey: 'input' } },
],
type: 1, webType: 1,
})
expect(issues.some(i => i.id === 'BS-60')).toBe(false)
})
it('BS-60: 字段显式 __vModel__ 不应触发', () => {
const issues = runGuards(baseCtx, {
fields: [
{ __vModel__: 'f_name', __config__: { label: 'x', jnpfKey: 'input' } },
],
type: 1, webType: 1,
})
expect(issues.some(i => i.id === 'BS-60')).toBe(false)
})
})