chore(lint): 清掉 4 条既有 clippy 告警,启用 -D warnings 闸门

**影响**
`cargo clippy --lib --all-targets -- -D warnings` 从「必然失败(4 条既有告警)」变为 **0 告警通过**,
后续任务可以直接把它当闸门用(此前 Task 3 round 5 的实现者因这 4 条告警无法验证自己的改动)。

**改动**
- `src/db.rs:329` / `:374`:`needless_range_loop` ⇒ 改用 `for row in &rows` 直接迭代行。
- `src/db.rs:352`:`needless_question_mark` ⇒ `Ok(rows[0].get::<Option<String>>(0)?)` ⇒ `rows[0].get::<Option<String>>(0)`。
- `src/main.rs:77` / `:81`:`ptr_arg` ⇒ `&PathBuf` ⇒ `&Path`(`identity_path` / `read_identity`),
  导入改为 `use std::path::{Path, PathBuf};`。

**设计**
纯机械等价改写:不改查询语义、不改返回类型、不改调用点(`&PathBuf` → `&Path` 由 deref 强转自动成立)。
`cargo test` 全绿:109 + 7 + 1 + 2 doctests,0 失败。

Co-Authored-By: Claude Code <[email protected]>
This commit is contained in:
adminandClaude Code committed 2026-10-24 20:07:48 +08:00
1 parent 8db55d1220
commit a86611d4cf
2 files changed
+9 -9

No files matched your search

+6 -6
View File
@@ -326,8 +326,8 @@ pub async fn query_json_params(
let wrapped = format!("SELECT row_to_json(q)::text AS _row FROM ({}) AS q", trimmed);
let rows = db.query(&wrapped, params).await?;
let mut out = Vec::with_capacity(rows.len());
for i in 0..rows.len() {
let s: Option<String> = rows[i].get(0)?;
for row in &rows {
let s: Option<String> = row.get(0)?;
match s {
Some(t) => match serde_json::from_str::<Value>(&t) {
Ok(v) => out.push(v),
@@ -349,7 +349,7 @@ pub async fn query_scalar_text(
if rows.is_empty() {
return Ok(None);
}
Ok(rows[0].get::<Option<String>>(0)?)
rows[0].get::<Option<String>>(0)
}
/// 列名 → PG 类型文本(`character varying(50)` / `bigint` / `timestamp without time zone` …)。
@@ -371,9 +371,9 @@ pub async fn column_types(db: &PGlite, table: &str) -> Result<HashMap<String, St
);
let rows = db.query(&sql, &[]).await?;
let mut out = HashMap::new();
for i in 0..rows.len() {
let name: Option<String> = rows[i].get(0)?;
let ty: Option<String> = rows[i].get(1)?;
for row in &rows {
let name: Option<String> = row.get(0)?;
let ty: Option<String> = row.get(1)?;
if let (Some(name), Some(ty)) = (name, ty) {
out.insert(name, ty);
}
+3 -3
View File
@@ -16,7 +16,7 @@
//! 本文件里剩下的 `/api/db/*` 与 `/api/ssw/tdc/node/*` 是**旧控制台**的遗留端点,
//! Task 10 统一下线。
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use std::sync::Arc;
use axum::{
@@ -74,11 +74,11 @@ fn now_iso() -> String {
Utc::now().to_rfc3339()
}
fn identity_path(data_dir: &PathBuf) -> PathBuf {
fn identity_path(data_dir: &Path) -> PathBuf {
data_dir.join("node-identity.json")
}
fn read_identity(data_dir: &PathBuf) -> Option<NodeIdentity> {
fn read_identity(data_dir: &Path) -> Option<NodeIdentity> {
let p = identity_path(data_dir);
if !p.exists() {
return None;